Set transport.Version via ldflags for release #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most things consuming this package, they will depend on an actual released version of go-containerregistry. When we release go-containerregistry itself, the binaries are built at the same version as the library, which means that they don't depend on an actual released version of go-containerregistry, so the version in debug info is just "(devel)". For our own release, we will just set it to the tag.
Codecov Report
@@ Coverage Diff @@
## master #856 +/- ##
==========================================
- Coverage 74.32% 74.29% -0.04%
==========================================
Files 106 106
Lines 4452 4454 +2
==========================================
Hits 3309 3309
- Misses 650 651 +1
- Partials 493 494 +1
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most things consuming this package, they will depend on an actual
released version of go-containerregistry. When we release
go-containerregistry itself, the binaries are built at the same version
as the library, which means that they don't depend on an actual released
version of go-containerregistry, so the version in debug info is just
"(devel)". For our own release, we will just set it to the tag.
Tested via:
Before:
The real test will be looking at the UA of a downstream module to make sure the buildinfo stuff works.